You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is to save the watched video duration for various videos, so that they can resume playing from where they left off.
In the current implementation, I am saving time_stamps in session storage, so these persist only for the current session.
I am expecting it to make persistent in future PRs.
Since the persistent version would have to be done quite differently, would prefer we just do that first. I wrote out an implementation plan here if you or anyone else would like to give it a shot: #155 (comment)
Code Robustness The extraction of video_id from the URL is fragile and may fail if the URL structure changes or includes additional parameters before the video ID. Consider using URLSearchParams for a more robust solution.
Error Handling There is no error handling for cases where sessionStorage might be disabled or full, which could lead to unhandled exceptions.
Code Duplication The sessionStorage.getItem(video_id) is called twice, which is inefficient. Consider storing the result in a variable and reusing it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
This PR is to save the watched video duration for various videos, so that they can resume playing from where they left off.
In the current implementation, I am saving time_stamps in session storage, so these persist only for the current session.
I am expecting it to make persistent in future PRs.
Demo
demo video